This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: results not being reset when appending to query param #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue where the AI search results were not being reset when you append your search to an existing query param (typically when you've come from quick search). This is because `handleSearch()` doesn't get called in this situation. So here we explicitly check for query params, trigger a reset and search for those occasions. Testing needs to be improved quite a bit here so I will address it in a follow-up PR.
keegangeorge
commented
Nov 12, 2024
Comment on lines
-26
to
+28
| @tracked AIResults = []; | ||
| @tracked showingAIResults = false; | ||
| @tracked AiResults = []; | ||
| @tracked showingAiResults = false; |
Member
Author
There was a problem hiding this comment.
I'm sneaking in a small change to make sure AI respects camelCase as we do so throughout the rest of the plugin.
keegangeorge
commented
Nov 12, 2024
| <DToggleSwitch | ||
| disabled={{this.disableToggleSwitch}} | ||
| @state={{this.showingAIResults}} | ||
| title="AI search results hidden" |
Member
Author
There was a problem hiding this comment.
title is not really necessary here as we show these details in this.searchStateText below, plus this should be localized anyway if it's used.
xfalcox
approved these changes
Nov 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the AI search results were not being reset when you append your search to an existing query param (typically when you've come from quick search). This is because
handleSearch()doesn't get called in this situation. So here we explicitly check for query params, trigger a reset and search for those occasions. Testing needs to be improved quite a bit here so I will address it in a follow-up PR.